Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the compatibility problem of serve() in Node 18 #2

Merged
merged 2 commits into from
May 23, 2022
Merged

Fixed the compatibility problem of serve() in Node 18 #2

merged 2 commits into from
May 23, 2022

Conversation

UlyssesZh
Copy link

Becasue of this issue, for Node version v18.0.0 or later, the family property in each item of os.networkInterfaces() becomes an integer 4 or 6 instead of a string "IPv4" or "IPv6". This pull request added a judge according to the version of Node.js.

@NonSpicyBurrito
Copy link
Collaborator

Please:

  • Change merge target branch to develop.
  • Run npm run lint and fix typing and formatting issues.

If you have trouble with typing the filter function, simply move it directly into .filter().

@UlyssesZh UlyssesZh changed the base branch from master to develop May 23, 2022 14:27
@UlyssesZh
Copy link
Author

Please:

  • Change merge target branch to develop.
  • Run npm run lint and fix typing and formatting issues.

If you have trouble with typing the filter function, simply move it directly into .filter().

Done!

@NonSpicyBurrito NonSpicyBurrito merged commit 1a0b171 into Sonolus:develop May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants