Remove code deprecations #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Can you please rebase and remove the CI work-around? |
HaHeho
force-pushed
the
remove-deprecations
branch
from
9265346 to
1de91a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw a lot of deprecation warnings when building and figured that some of them could be eliminated. I then noticed that all the
sprintf()deprecations come from the submodule libraries. Hence, only one warning is prevented (delta), and one kind of warning that occurs many times is silenced (OpenGL). The latter may be a warning exclusive to macOS (not sure).I have quickly verified the
QWheelEventchange (delta). The zoom of anssr-binauralscene worked for me as before (tested on macOS).To see the other builds succeed, I have temporarily disabled the two failing macOS CI build configurations, as mentioned in #380. These should not be merged and treated separately.