Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The callback queue should be per-AMX #20

Closed
kristoisberg opened this issue Jan 2, 2019 · 0 comments
Closed

The callback queue should be per-AMX #20

kristoisberg opened this issue Jan 2, 2019 · 0 comments

Comments

@kristoisberg
Copy link
Contributor

Currently it's global and if multiple AMX instances are loaded, it will spam out errors about the function not being found.
Southclaws added a commit that referenced this issue Jan 2, 2019
@Southclaws
added an AMX* property to callback events
5e4e5c5 
This change addresses #20 by providing a way of associating RequestData
and ResponseData objects to specific AMX instances. Unfortunately this
breaks the isolation of impl.* files from AMX and SA:MP related code but
it's a necessary change. When a request is created, the address of the
AMX it is called from is stored into the request object which is then
passed on to the response object when the request has finished. During
the processTick function, each queued responses' AMX address is then
checked against the AMX that called processTick to ensure no duplicate
events are dispatched to AMX instances.
@Southclaws Southclaws mentioned this issue Jan 2, 2019
Merged
@Haytam95 Haytam95 mentioned this issue Jan 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Southclaws @kristoisberg