Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add oci as assets client #238

Merged
merged 1 commit into from
Sep 5, 2024
Merged

✨ Add oci as assets client #238

merged 1 commit into from
Sep 5, 2024

Conversation

janiskemper
Copy link
Member

What this PR does / why we need it:
Implemented the oci client to download artifacts from an oci registry.

Which issue(s) this PR fixes:
Fixes #157

TODOs:

  • squash commits
  • include documentation
  • add unit tests

@jschoone jschoone self-requested a review August 13, 2024 07:00
@jschoone
Copy link
Contributor

Hi @janiskemper, is this still a Draft? For me it worked so far.
How much effort will it be to add the oci support to CSPO? Can the code be reused there since they basically do the same thing?

@janiskemper
Copy link
Member Author

It's just a draft because I created it as such. If it works for you, it's great! For me we can merge it! The clients should work out of the box and can be imported also from CSPO!

@chess-knight
Copy link
Member

I think that we should also add support for OCI_USERNAME and OCI_PASSWORD here in the same way as in SovereignCloudStack/csctl#146

@jschoone
Copy link
Contributor

I think that we should also add support for OCI_USERNAME and OCI_PASSWORD here in the same way as in SovereignCloudStack/csctl#146

@janiskemper could you add this?

@chess-knight
Copy link
Member

I think that we should also add support for OCI_USERNAME and OCI_PASSWORD here in the same way as in SovereignCloudStack/csctl#146

@janiskemper could you add this?

I can do it, it looks like I need it for oci integration tests in SovereignCloudStack/cluster-stack-provider-openstack#198 if I want to use SCS Registry(@jschoone I tried downloading the release from your csctl-oci/openstack). Also, I did it in csctl.

@janiskemper
Copy link
Member Author

thanks @chess-knight

Copy link
Member Author

@janiskemper janiskemper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jschoone looks good from my side. What's the next step?

@chess-knight
Copy link
Member

What's the next step?

IMO we should merge this one and also create a new CSO release for R7.

@janiskemper janiskemper marked this pull request as ready for review September 2, 2024 10:50
@chess-knight chess-knight force-pushed the oci-client branch 8 times, most recently from a76031e to aace609 Compare September 4, 2024 11:48
Implemented the oci client to download artifacts from an oci registry.

Signed-off-by: Janis Kemper <janis.kemper@syself.com>
Co-authored-by: Roman Hros <roman.hros@dnation.cloud>
@chess-knight chess-knight merged commit 4118b3e into main Sep 5, 2024
6 checks passed
@chess-knight chess-knight deleted the oci-client branch September 5, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OCI registry as alternative to storing release assets in Github
4 participants