-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add oci as assets client #238
Conversation
Hi @janiskemper, is this still a Draft? For me it worked so far. |
It's just a draft because I created it as such. If it works for you, it's great! For me we can merge it! The clients should work out of the box and can be imported also from CSPO! |
I think that we should also add support for |
@janiskemper could you add this? |
I can do it, it looks like I need it for oci integration tests in SovereignCloudStack/cluster-stack-provider-openstack#198 if I want to use SCS Registry(@jschoone I tried downloading the release from your csctl-oci/openstack). Also, I did it in csctl. |
thanks @chess-knight |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jschoone looks good from my side. What's the next step?
IMO we should merge this one and also create a new CSO release for R7. |
d479eab
to
fe31669
Compare
a76031e
to
aace609
Compare
51b26fc
to
5b1a519
Compare
6f3c9cc
to
3ecc981
Compare
Implemented the oci client to download artifacts from an oci registry. Signed-off-by: Janis Kemper <janis.kemper@syself.com> Co-authored-by: Roman Hros <roman.hros@dnation.cloud>
3ecc981
to
6a0d442
Compare
What this PR does / why we need it:
Implemented the oci client to download artifacts from an oci registry.
Which issue(s) this PR fixes:
Fixes #157
TODOs: