✨ Update to CAPI 1.8 #255
Merged
✨ Update to CAPI 1.8 #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guettli
force-pushed
the
tg/update-to-capi-1.8
branch
from
ae29644
to
8b5daba
Compare
|
@guettli are you sure the dependencies are in sync with CAPI? I think CAPI uses K8s 1.30.x in their 1.8 release. Here is a quote from their release notes:
|
guettli
force-pushed
the
tg/update-to-capi-1.8
branch
from
99dbf7d
to
fbc0c69
Compare
yes, you are right. I took the cluster api main branch, which uses slightly higher versions of the dependencies. I switched to capi tag v1.8.1 and took their go.mod file as template. |
Signed-off-by: Thomas Guettler <thomas.guettler@syself.com>
guettli
force-pushed
the
tg/update-to-capi-1.8
branch
from
fbc0c69
to
21ab08d
Compare
janiskemper
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs update to a newer Go version.
About update of controller-runtime:
https://kubernetes.slack.com/archives/C02MRBMN00Z/p1713976216050739
What this PR does / why we need it:
We want to upgrade to CAPI 1.8
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #251
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs: