Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kustomization of nginx ingress #329

Closed
wants to merge 1 commit into from
Closed

Fix kustomization of nginx ingress #329

wants to merge 1 commit into from

Conversation

jschoone
Copy link
Contributor

@jschoone jschoone commented Feb 24, 2023 •
edited
Loading

Fixes #328

@jschoone
fix(apply_nginx): kustomize build errors while kubectl kustomize work…
6328b8f 
…s fine

Signed-off-by: Jan Schoone <schoone@osb-alliance.com>
chess-knight
chess-knight approved these changes Feb 27, 2023
View reviewed changes
Copy link
Member

@chess-knight chess-knight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it and it seems it works.

@garloff
Copy link
Member

garloff commented Feb 27, 2023

As per discussion in the Container Team meeting:

  • kustomize has changed upstream and we probably need to adjust our kustomization for it to pass
  • kubectl kustomize still has an older version of kustomize included which is the reason for it to still work
  • As soon as the kubectl included kustomize gets revved, we'd break again

Suggested way forward:
(a) Adjust the kustomization files such that they are processed successfuly through kustomize v5
Only if this fails:
(b) Find a way to reliably get and pin an older version of kustomize (via kubectl or directly)

@garloff
Copy link
Member

garloff commented Mar 1, 2023

Reading through kubernetes-sigs/kustomize#4911, I guess that we just need to replace patches: with patchesStrategicMerge: in the kustomization files to be compatible with kustomize v5 (and v3).

@garloff
Copy link
Member

garloff commented Mar 1, 2023

Better to fully update the syntax and use resources instead of base and patches:\n - path: FILENAME instead of patchesStrategicMerge:\n - FILENAME.

garloff added a commit that referenced this pull request Mar 1, 2023
@garloff
Adjust to new kustomize syntax.
16516b8 
Use resources rather than base.
Insert path: before filenames referenced in patches.
Reference: kubernetes-sigs/kustomize#4911
Supercedes: #329

Signed-off-by: Kurt Garloff <kurt@garloff.de>
garloff added a commit that referenced this pull request Mar 1, 2023
@garloff
Adjust to new kustomize syntax.
91d0ca9 
Use resources rather than base.
Insert path: before filenames referenced in patches.
Reference: kubernetes-sigs/kustomize#4911
Supercedes: #329

Signed-off-by: Kurt Garloff <kurt@garloff.de>
@garloff garloff mentioned this pull request Mar 1, 2023
Merged
@garloff
Copy link
Member

garloff commented Mar 1, 2023

Please review #348 .

@garloff garloff added the work in progress Pull requests that are work in progress, do not merge them label Mar 3, 2023
garloff added a commit that referenced this pull request Mar 5, 2023
@garloff
Adjust to new kustomize syntax.
c5c155d 
Use resources rather than base.
Insert path: before filenames referenced in patches.
Reference: kubernetes-sigs/kustomize#4911
Supercedes: #329

Signed-off-by: Kurt Garloff <kurt@garloff.de>
@jschoone jschoone closed this Mar 5, 2023
@jschoone jschoone deleted the fix/#328-kustomize-fix branch March 5, 2023 21:17
garloff added a commit that referenced this pull request Mar 5, 2023
@garloff
Adjust to new kustomize syntax. (#348)
57f662b 
Use resources rather than base.
Insert path: before filenames referenced in patches.
Reference: kubernetes-sigs/kustomize#4911
Supercedes: #329

Signed-off-by: Kurt Garloff <kurt@garloff.de>
garloff added a commit that referenced this pull request Mar 10, 2023
@garloff
Adjust to new kustomize syntax. (#348)
aac4f76 
Use resources rather than base.
Insert path: before filenames referenced in patches.
Reference: kubernetes-sigs/kustomize#4911
Supercedes: #329

Signed-off-by: Kurt Garloff <kurt@garloff.de>
garloff added a commit that referenced this pull request Mar 10, 2023
@garloff
Adjust to new kustomize syntax. (#348)
9e2a9aa 
Use resources rather than base.
Insert path: before filenames referenced in patches.
Reference: kubernetes-sigs/kustomize#4911
Supercedes: #329

Signed-off-by: Kurt Garloff <kurt@garloff.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chess-knight chess-knight chess-knight approved these changes

@batistein batistein batistein approved these changes

@garloff garloff Awaiting requested review from garloff

@matofeder matofeder Awaiting requested review from matofeder

Assignees
No one assigned
Labels
work in progress Pull requests that are work in progress, do not merge them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kustomize errors when building nginx manifests
4 participants
@jschoone @garloff @batistein @chess-knight