Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-upgrade to v4 #54

Closed
wants to merge 124 commits into from
Closed

Pre-upgrade to v4 #54

wants to merge 124 commits into from

Conversation

Ephellon
Copy link
Collaborator

@Ephellon Ephellon commented Aug 7, 2018

Hi @SpaceK33z, I've made most of the changes noted in your comment here, with the following not done:

Not Done

What Why
remove adblockplus.txt I was planning on using it as a custom filter list; but that's later on
installed make I'm not sure how to use make yet
made comment changes I need to re-read the code and add comments for human readability

Ephellon added 30 commits May 2, 2018 21:10
Removed CouchPotato (unused).
Added Sonarr.
Removed (commented out) CouchPotato settings, and added Sonarr settings. Also added Flenix.co as a supported website.
Fixed Flenix bug of downloading. CHanged button style too.
The Flenix button now shows as "Download File (index/length)"
Added multiple Flenix download locations (header and footer). Optimized source code. Changed Web to Plex+ logos.
Renamed `image.png` and added `256.png`
Created a new UI
Added links to external sites: Radarr, Plex, and Sonarr. Also added "In" and "En" sections.
Updated to 0.2.2.0, fixed the adding error
Added https://tvmaze.com/ support and fixed several bugs
Made minor fixes to utils.js (rerun-searchfeature). Added button
location images.
Fixed adding error (background.js)
Fixed the "radarr" onclick bug
Updated Amazon's layout accordingly.
Fixed typos
Added enw Amazon button location picture.
Fixed context menu error?
Fixed (changed) 404 for apache.
Made minor fixes. Also changed some GUI elements. Also added extra API
keys.
Fixed Radarr link on the options page.
Made changes to JS framework: titling, finding, and matching.
Made small changes to style (added common.css).
Added "flenix.tv" to sites.
Getting the repo ready for a pull request.

Also updated `String..toCaps` to include the "on" word.
Also updated the options to include the new "Plex | Server URL" feature.
Changed the status. Added to the "features" section.
@SpaceK33z
Copy link
Owner

SpaceK33z commented Aug 7, 2018

This PR has conflicting changes so I can't merge it like this. Could you rebase it on the latest master commit and then apply your changes? Maybe the simplest way would be to just clone SpaceK33z/web-to-plex again, remove all files in it and copy/paste your files from your fork and commit.

I was planning on using it as a custom filter list; but that's later on

Okay sure, if it's documented later on that's also fine, it was just confusing for me since there was no reference to this file in either the documentation or the code.

I'm not sure how to use make yet

make is a build tool a bit like Gulp (but way older than that). I have no attachment to using make so I'm fine with replacing it. But we can do that at the same time as we automate the release process (I realllly want to be able to just push the code to GitHub, and have the extension automatically uploaded to the Chrome and FireFox store). So anyway, you wouldn't need to learn it (it may be a handy skill to have though!).

@Ephellon Ephellon closed this Aug 7, 2018
@Ephellon Ephellon changed the title Upgrade to v4 Pre-upgrade to v4 Nov 27, 2018
@Ephellon Ephellon self-assigned this Jun 28, 2019
@Ephellon Ephellon added enhancement this item makes the project better in some way forked this was implemented in the newer version(s) from a fork/merge labels Jun 28, 2019
This was referenced Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement this item makes the project better in some way forked this was implemented in the newer version(s) from a fork/merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants