Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn about invalid filter() kwargs #154

Merged
merged 8 commits into from
Jan 22, 2020
Merged

Warn about invalid filter() kwargs #154

merged 8 commits into from
Jan 22, 2020

Conversation

spookydonut
Copy link
Collaborator

Removes a TODO and leaves a new one.

@SpaceManiac SpaceManiac changed the title Makes dreamchecker warn about invalid filter() kwargs Warn about invalid filter() kwargs Jan 21, 2020
@spookydonut
Copy link
Collaborator Author

Do not merge, this is not working correctly

@spookydonut
Copy link
Collaborator Author

Fixed it

@SpaceManiac SpaceManiac merged commit f3d4820 into SpaceManiac:master Jan 22, 2020
@spookydonut spookydonut mentioned this pull request Jan 23, 2020
Merged
@spookydonut spookydonut deleted the filterargs branch January 26, 2020 09:05
@ZeWaka ZeWaka mentioned this pull request Jul 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpaceManiac SpaceManiac SpaceManiac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spookydonut @SpaceManiac