Populate errortype on more errors. #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added unreachable_code, proc_has_no_parent, and loop_condition_determinate error types. - Added one use of control_condition_static where it was missing. - Added unit tests covering some of the error conditions I looked at while adding these.
|
@Leshana those errors are intentionally not able to be disabled. |
@spookydonut Could you elaborate on the reasoning for this? |
@SpaceManiac If people don't want errors raised by lints they should... not use those lints? |
Oh wait, nvm there's no reason not to allow these to be configged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is convenient for me when working on older codebases where I want to categorize and prioritize the types of linting errors to fix. In addition to the ones I wanted, @spookydonut 's code inspired a few additional ones to add.
Plus I figure more unit test coverage is always helpful.