Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.6 -> Main For Possible SW 1.6 #273

Merged
merged 22 commits into from
Dec 3, 2023
Merged

1.6 -> Main For Possible SW 1.6 #273

merged 22 commits into from
Dec 3, 2023

Conversation

cheese3660
Copy link
Member

This adds 2 things
Value constraints for configurations, and per save mod save data

Falki-git and others added 22 commits November 5, 2023 21:47
@Falki-git
Add API registration for mods that want to use game's built-in saving…
daf1d75 
… and loading of data stored in the save game files
@cheese3660
Allow for per campaign configuration with `CampaignConfiguration.Bind…
a80cedd 
…` in the mod base plugin
@cheese3660
Merge remote-tracking branch 'origin/dev' into dev
0ee26fa
@Falki-git
Registration returns T; T saveData is optional, default value of T is…
f74ad7c 
… created if parameter is omitted
@Falki-git
Typo
219d8ff
@cheese3660
Reset bindings for campaign configuration when returning to main menu
6338e33
@cheese3660
Merge pull request #270 from Falki-git/plugin-data-in-save-files
ea55371 
Add API registration for mods that want to use game's built-in saving and loading of data stored in the save game files
@cheese3660
Cleanup game data saving code
9495532
@cheese3660
A little bit more cleanup
8622e67
@cheese3660
Make the onSave/onLoad parameters default to to null
c828518
@cheese3660
Start work on Value Constraints
d2e0804
@cheese3660
Add space warp config constraints to the SpaceWarp settings UI
482e980
@cheese3660
Add callbacks for changed config values
087389d
@jan-bures
Only log an info message when a label doesn't exist in an Addressable…
850f747 
…Action
@cheese3660
Merge pull request #271 from SpaceWarpDev/label-log
5e4aec8 
Error logging in AddressableAction
@Falki-git
Fix: support when savedata is a dictionary
23c029c 
Previously plugin savedata could have only been a class with fields and properties.
Now dictionaries are also supported.

For example:
ModSaves.RegisterSaveLoadGameData<Dictionary<string, SaveDataAdapter>>(
            "My mod GUID",
            OnSave,
            OnLoad
        );
@cheese3660
Merge pull request #272 from Falki-git/Fix-when-savedata-is-a-dictionary
fc4ea7c 
Fix: support when savedata is a dictionary
@cheese3660
Revert "Reset bindings for campaign configuration when returning to m…
efe64f5 
…ain menu"

This reverts commit 6338e33.
@cheese3660
Revert "Allow for per campaign configuration with `CampaignConfigurat…
ea94f18 
…ion.Bind` in the mod base plugin"

This reverts commit a80cedd
@cheese3660
Update swinfo.json
a1af172
@cheese3660
Update Directory.Build.props
70d1044
@cheese3660
Update SpaceWarp.nuspec
65cf427
jan-bures
jan-bures approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@jan-bures jan-bures left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cheese3660 cheese3660 merged commit d7f4545 into main Dec 3, 2023
2 checks passed
@jan-bures jan-bures deleted the 1.6 branch December 20, 2023 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-bures jan-bures jan-bures approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cheese3660 @jan-bures @Falki-git