Skip to content

Commit

Permalink
Remove additional logging
Browse files Browse the repository at this point in the history
  • Loading branch information
epresi committed Apr 27, 2020
1 parent 27848f5 commit 9b473ab
Show file tree
Hide file tree
Showing 5 changed files with 2 additions and 30 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,11 @@ public FeatureCodeBehindGenerator(ITestGenerator testGenerator)
_testGenerator = testGenerator;
}

public TestFileGeneratorResult GenerateCodeBehindFile(string featureFile, TaskLoggingHelper log)
public TestFileGeneratorResult GenerateCodeBehindFile(string featureFile)
{
log.LogMessage(MessageImportance.High, $"[SpecFlow] FeatureFile: {featureFile}");

var featureFileInput = new FeatureFileInput(featureFile);
log.LogMessage(MessageImportance.High, $"[SpecFlow] FeatureFileInfo: {featureFileInput.ToString()}");

var generatedFeatureFileName = Path.GetFileName(_testGenerator.GetTestFullPath(featureFileInput));
log.LogMessage(MessageImportance.High, $"[SpecFlow] GeneratedFeatureFileName: {generatedFeatureFileName}");

var testGeneratorResult = _testGenerator.GenerateTestFile(featureFileInput, new GenerationSettings());

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public IEnumerable<string> GenerateFilesForProject(
foreach (var featureFile in featureFiles)
{
string featureFileItemSpec = featureFile;
var generatorResult = _featureCodeBehindGenerator.GenerateCodeBehindFile(featureFileItemSpec, Log);
var generatorResult = _featureCodeBehindGenerator.GenerateCodeBehindFile(featureFileItemSpec);

if (!generatorResult.Success)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,10 @@ public override bool Execute()
var generateFeatureFileCodeBehindTaskContainerBuilder = new GenerateFeatureFileCodeBehindTaskContainerBuilder();
var generatorPlugins = GeneratorPlugins?.Select(gp => gp.ItemSpec).Select(p => new GeneratorPluginInfo(p)).ToArray() ?? Array.Empty<GeneratorPluginInfo>();
var featureFiles = FeatureFiles?.Select(i => i.ItemSpec).ToArray() ?? Array.Empty<string>();
Log.LogMessage(MessageImportance.High, $"[SpecFlow] FeatureFiles from BuildTask: {string.Join(", ", featureFiles)}");

var msbuildInformationProvider = new MSBuildInformationProvider(MSBuildVersion);
var generateFeatureFileCodeBehindTaskConfiguration = new GenerateFeatureFileCodeBehindTaskConfiguration(AnalyticsTransmitter, CodeBehindGenerator);
var generateFeatureFileCodeBehindTaskInfo = new SpecFlowProjectInfo(generatorPlugins, featureFiles, ProjectPath, ProjectFolder, ProjectGuid, AssemblyName, OutputPath, RootNamespace, TargetFrameworks, TargetFramework);
Log.LogMessage(MessageImportance.High, $"[SpecFlow] ProjectInfo: {generateFeatureFileCodeBehindTaskInfo.ToString()}");

using (var taskRootContainer = generateFeatureFileCodeBehindTaskContainerBuilder.BuildRootContainer(Log, generateFeatureFileCodeBehindTaskInfo, msbuildInformationProvider, generateFeatureFileCodeBehindTaskConfiguration))
{
Expand Down
15 changes: 0 additions & 15 deletions SpecFlow.Tools.MsBuild.Generation/SpecFlowProjectInfo.cs
Original file line number Diff line number Diff line change
Expand Up @@ -65,20 +65,5 @@ private bool InvalidFileName(string featureFilePath)
return !string.IsNullOrEmpty(featureFileName) &&
featureFileName.Any(s => invalidCharacters.Contains(s));
}

public override string ToString()
{
return $"GeneratorPlugins: '{string.Join(", ", GeneratorPlugins)}', "
+ $"FeatureFiles: '{string.Join(", ", FeatureFiles)}', "
+ $"ProjectPath: '{ProjectPath}', "
+ $"ProjectFolder: '{ProjectFolder}', "
+ $"ProjectGuid: '{ProjectGuid}', "
+ $"ProjectAssemblyName: '{ProjectAssemblyName}', "
+ $"OutputPath: '{OutputPath}', "
+ $"RootNamespace: '{RootNamespace}', "
+ $"TargetFrameworks: '{TargetFrameworks}', "
+ $"CurrentTargetFramework: '{CurrentTargetFramework}', "
;
}
}
}
7 changes: 0 additions & 7 deletions TechTalk.SpecFlow.Generator/Interfaces/FeatureFileInput.cs
Original file line number Diff line number Diff line change
Expand Up @@ -45,12 +45,5 @@ public FeatureFileInput(string projectRelativePath)

ProjectRelativePath = projectRelativePath;
}

public override string ToString()
{
return $"ProjectRelativePath: '{ProjectRelativePath}', "
+ $"CustomNamespace: '{CustomNamespace}', "
+ $"GeneratedTestProjectRelativePath: '{GeneratedTestProjectRelativePath}'";
}
}
}

0 comments on commit 9b473ab

Please sign in to comment.