Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created VerifyAllColumnsBound check #1949

Merged
merged 1 commit into from
Apr 27, 2020
Merged

Created VerifyAllColumnsBound check #1949

merged 1 commit into from
Apr 27, 2020

Conversation

304NotModified
Copy link
Contributor

@304NotModified 304NotModified commented Apr 18, 2020

with InstanceCreationOptions/VerifyAllColumnsBound

examples:

var options = new InstanceCreationOptions { VerifyAllColumnsBound = true };
var persons = table.CreateSet<Person>(options);
var options = new InstanceCreationOptions { VerifyAllColumnsBound = true };
var person = table.CreateInstance<Person>(options);
  • binary compatible
  • forward compatible for more changes in the future

If you have prefer other names for the classes/options, let me know

fixes #1943

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • I've added tests for my code. (most of the time mandatory)
  • I have added an entry to the changelog. (mandatory)
  • My change requires a change to the documentation. (not sure!)
  • I have updated the documentation accordingly. (where?)

with InstanceCreationOptions

- binary compatible
- forward compatible for more changes in the future
@304NotModified 304NotModified marked this pull request as ready for review April 21, 2020 18:35
@SabotageAndi SabotageAndi merged commit d233b2a into SpecFlowOSS:master Apr 27, 2020
@SabotageAndi
Copy link
Contributor

Thanks for this PR. You added a really missed feature.

@304NotModified 304NotModified deleted the verifyAllColumnsBound branch May 5, 2020 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request - verify if all columns are bound - PR accepted?
2 participants