Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify ServiceComponentList #2566

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

bollhals
Copy link
Contributor

@bollhals bollhals commented Mar 9, 2022

This change simplifies the ServiceComponentList by changing the way the default is handled.

Instead of using a ValueHolder and concating it at the end of the list, it's now added at the end of the list and kept track of it.

Side changes included:

  • Sorted the ValueRetriever by likelyhood of usage (as we're iterating over each retriever front to back to find the one that can convert the value)
  • Simplify creating the list of Retrievers/Comparers by adding a new internal ctor, this avoids the repetitive List<T>.Insert(0, ...) calls in Register.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Performance improvement
  • Refactoring (so no functional change)
  • Other (docs, build config, etc)

Checklist:

  • I've added tests for my code. (most of the time mandatory)
  • I have added an entry to the changelog. (mandatory)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@SabotageAndi SabotageAndi merged commit 5a732c6 into SpecFlowOSS:master Mar 10, 2022
@bollhals bollhals deleted the feature/ServiceComponent branch March 10, 2022 09:14
Code-Grump pushed a commit to Code-Grump/SpecFlow that referenced this pull request Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants