Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the ability to call a step from a step via string #2631

Merged
merged 4 commits into from
Aug 5, 2022
Merged

Remove the ability to call a step from a step via string #2631

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bb02a4a
remove the ability to call a step from a step via string
SabotageAndi Aug 4, 2022
485935d
update changelog
SabotageAndi Aug 4, 2022
f077acb
update documentation
SabotageAndi Aug 4, 2022
f735289
add breaking change documentation
SabotageAndi Aug 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
305 changes: 0 additions & 305 deletions TechTalk.SpecFlow/Steps.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,6 @@ namespace TechTalk.SpecFlow
{
public abstract class Steps : IContainerDependentObject
{
private const string GivenObsoleteMessage = $"{nameof(Steps)}.{nameof(Given)} and {nameof(Steps)}.{nameof(GivenAsync)} are obsolete and will be removed with SpecFlow 4.0. Details: https://github.com/techtalk/SpecFlow/issues/1733";
private const string WhenObsoleteMessage = $"{nameof(Steps)}.{nameof(When)} and {nameof(Steps)}.{nameof(WhenAsync)} are obsolete and will be removed with SpecFlow 4.0. Details: https://github.com/techtalk/SpecFlow/issues/1733";
private const string ThenObsoleteMessage = $"{nameof(Steps)}.{nameof(Then)} and {nameof(Steps)}.{nameof(ThenAsync)} are obsolete and will be removed with SpecFlow 4.0. Details: https://github.com/techtalk/SpecFlow/issues/1733";
private const string ButObsoleteMessage = $"{nameof(Steps)}.{nameof(And)} and {nameof(Steps)}.{nameof(AndAsync)} are obsolete and will be removed with SpecFlow 4.0. Details: https://github.com/techtalk/SpecFlow/issues/1733";
private const string AndObsoleteMessage = $"{nameof(Steps)}.{nameof(But)} and {nameof(Steps)}.{nameof(ButAsync)} are obsolete and will be removed with SpecFlow 4.0. Details: https://github.com/techtalk/SpecFlow/issues/1733";
private IObjectContainer objectContainer;

void IContainerDependentObject.SetObjectContainer(IObjectContainer container)
Expand Down Expand Up @@ -83,305 +78,5 @@ protected void AssertInitialized()
if (objectContainer == null)
throw new SpecFlowException("Container of the steps class has not been initialized!");
}

#region GivenAsync
[Obsolete(GivenObsoleteMessage)]
[EditorBrowsable(EditorBrowsableState.Never)]
public async Task GivenAsync(string step)
{
await GivenAsync(step, null, null);
}

[Obsolete(GivenObsoleteMessage)]
[EditorBrowsable(EditorBrowsableState.Never)]
public async Task GivenAsync(string step, Table tableArg)
{
await GivenAsync(step, null, tableArg);
}

[Obsolete(GivenObsoleteMessage)]
[EditorBrowsable(EditorBrowsableState.Never)]
public async Task GivenAsync(string step, string multilineTextArg)
{
await GivenAsync(step, multilineTextArg, null);
}

[Obsolete(GivenObsoleteMessage)]
[EditorBrowsable(EditorBrowsableState.Never)]
public async Task GivenAsync(string step, string multilineTextArg, Table tableArg)
{
await TestRunner.GivenAsync(step, multilineTextArg, tableArg);
}
#endregion

#region WhenAsync
[Obsolete(WhenObsoleteMessage)]
[EditorBrowsable(EditorBrowsableState.Never)]
public async Task WhenAsync(string step)
{
await WhenAsync(step, null, null);
}

[Obsolete(WhenObsoleteMessage)]
[EditorBrowsable(EditorBrowsableState.Never)]
public async Task WhenAsync(string step, Table tableArg)
{
await WhenAsync(step, null, tableArg);
}

[Obsolete(WhenObsoleteMessage)]
[EditorBrowsable(EditorBrowsableState.Never)]
public async Task WhenAsync(string step, string multilineTextArg)
{
await WhenAsync(step, multilineTextArg, null);
}

[Obsolete(WhenObsoleteMessage)]
[EditorBrowsable(EditorBrowsableState.Never)]
public async Task WhenAsync(string step, string multilineTextArg, Table tableArg)
{
await TestRunner.WhenAsync(step, multilineTextArg, tableArg);
}
#endregion

#region ThenAsync
[Obsolete(ThenObsoleteMessage)]
[EditorBrowsable(EditorBrowsableState.Never)]
public async Task ThenAsync(string step)
{
await ThenAsync(step, null, null);
}

[Obsolete(ThenObsoleteMessage)]
[EditorBrowsable(EditorBrowsableState.Never)]
public async Task ThenAsync(string step, Table tableArg)
{
await ThenAsync(step, null, tableArg);
}

[Obsolete(ThenObsoleteMessage)]
[EditorBrowsable(EditorBrowsableState.Never)]
public async Task ThenAsync(string step, string multilineTextArg)
{
await ThenAsync(step, multilineTextArg, null);
}

[Obsolete(ThenObsoleteMessage)]
[EditorBrowsable(EditorBrowsableState.Never)]
public async Task ThenAsync(string step, string multilineTextArg, Table tableArg)
{
await TestRunner.ThenAsync(step, multilineTextArg, tableArg);
}
#endregion

#region ButAsync
[Obsolete(ButObsoleteMessage)]
[EditorBrowsable(EditorBrowsableState.Never)]
public async Task ButAsync(string step)
{
await ButAsync(step, null, null);
}

[Obsolete(ButObsoleteMessage)]
[EditorBrowsable(EditorBrowsableState.Never)]
public async Task ButAsync(string step, Table tableArg)
{
await ButAsync(step, null, tableArg);
}

[Obsolete(ButObsoleteMessage)]
[EditorBrowsable(EditorBrowsableState.Never)]
public async Task ButAsync(string step, string multilineTextArg)
{
await ButAsync(step, multilineTextArg, null);
}

[Obsolete(ButObsoleteMessage)]
[EditorBrowsable(EditorBrowsableState.Never)]
public async Task ButAsync(string step, string multilineTextArg, Table tableArg)
{
await TestRunner.ButAsync(step, multilineTextArg, tableArg);
}
#endregion

#region AndAsync
[Obsolete(AndObsoleteMessage)]
[EditorBrowsable(EditorBrowsableState.Never)]
public async Task AndAsync(string step)
{
await AndAsync(step, null, null);
}

[Obsolete(AndObsoleteMessage)]
[EditorBrowsable(EditorBrowsableState.Never)]
public async Task AndAsync(string step, Table tableArg)
{
await AndAsync(step, null, tableArg);
}

[Obsolete(AndObsoleteMessage)]
[EditorBrowsable(EditorBrowsableState.Never)]
public async Task AndAsync(string step, string multilineTextArg)
{
await AndAsync(step, multilineTextArg, null);
}

[Obsolete(AndObsoleteMessage)]
[EditorBrowsable(EditorBrowsableState.Never)]
public async Task AndAsync(string step, string multilineTextArg, Table tableArg)
{
await TestRunner.AndAsync(step, multilineTextArg, tableArg);
}
#endregion

#region Given
[Obsolete(GivenObsoleteMessage)]
[EditorBrowsable(EditorBrowsableState.Never)]
public void Given(string step)
{
Given(step, null, null);
}

[Obsolete(GivenObsoleteMessage)]
[EditorBrowsable(EditorBrowsableState.Never)]
public void Given(string step, Table tableArg)
{
Given(step, null, tableArg);
}

[Obsolete(GivenObsoleteMessage)]
[EditorBrowsable(EditorBrowsableState.Never)]
public void Given(string step, string multilineTextArg)
{
Given(step, multilineTextArg, null);
}

[Obsolete(GivenObsoleteMessage)]
[EditorBrowsable(EditorBrowsableState.Never)]
public void Given(string step, string multilineTextArg, Table tableArg)
{
SyncTestRunner.Given(step, multilineTextArg, tableArg);
}
#endregion

#region When
[Obsolete(WhenObsoleteMessage)]
[EditorBrowsable(EditorBrowsableState.Never)]
public void When(string step)
{
When(step, null, null);
}

[Obsolete(WhenObsoleteMessage)]
[EditorBrowsable(EditorBrowsableState.Never)]
public void When(string step, Table tableArg)
{
When(step, null, tableArg);
}

[Obsolete(WhenObsoleteMessage)]
[EditorBrowsable(EditorBrowsableState.Never)]
public void When(string step, string multilineTextArg)
{
When(step, multilineTextArg, null);
}

[Obsolete(WhenObsoleteMessage)]
[EditorBrowsable(EditorBrowsableState.Never)]
public void When(string step, string multilineTextArg, Table tableArg)
{
SyncTestRunner.When(step, multilineTextArg, tableArg);
}
#endregion

#region Then
[Obsolete(ThenObsoleteMessage)]
[EditorBrowsable(EditorBrowsableState.Never)]
public void Then(string step)
{
Then(step, null, null);
}

[Obsolete(ThenObsoleteMessage)]
[EditorBrowsable(EditorBrowsableState.Never)]
public void Then(string step, Table tableArg)
{
Then(step, null, tableArg);
}

[Obsolete(ThenObsoleteMessage)]
[EditorBrowsable(EditorBrowsableState.Never)]
public void Then(string step, string multilineTextArg)
{
Then(step, multilineTextArg, null);
}

[Obsolete(ThenObsoleteMessage)]
[EditorBrowsable(EditorBrowsableState.Never)]
public void Then(string step, string multilineTextArg, Table tableArg)
{
SyncTestRunner.Then(step, multilineTextArg, tableArg);
}
#endregion

#region But
[Obsolete(ButObsoleteMessage)]
[EditorBrowsable(EditorBrowsableState.Never)]
public void But(string step)
{
But(step, null, null);
}

[Obsolete(ButObsoleteMessage)]
[EditorBrowsable(EditorBrowsableState.Never)]
public void But(string step, Table tableArg)
{
But(step, null, tableArg);
}

[Obsolete(ButObsoleteMessage)]
[EditorBrowsable(EditorBrowsableState.Never)]
public void But(string step, string multilineTextArg)
{
But(step, multilineTextArg, null);
}

[Obsolete(ButObsoleteMessage)]
[EditorBrowsable(EditorBrowsableState.Never)]
public void But(string step, string multilineTextArg, Table tableArg)
{
SyncTestRunner.But(step, multilineTextArg, tableArg);
}
#endregion

#region And
[Obsolete(AndObsoleteMessage)]
[EditorBrowsable(EditorBrowsableState.Never)]
public void And(string step)
{
And(step, null, null);
}

[Obsolete(AndObsoleteMessage)]
[EditorBrowsable(EditorBrowsableState.Never)]
public void And(string step, Table tableArg)
{
And(step, null, tableArg);
}

[Obsolete(AndObsoleteMessage)]
[EditorBrowsable(EditorBrowsableState.Never)]
public void And(string step, string multilineTextArg)
{
And(step, multilineTextArg, null);
}

[Obsolete(AndObsoleteMessage)]
[EditorBrowsable(EditorBrowsableState.Never)]
public void And(string step, string multilineTextArg, Table tableArg)
{
SyncTestRunner.And(step, multilineTextArg, tableArg);
}
#endregion
}
}
75 changes: 0 additions & 75 deletions Tests/TechTalk.SpecFlow.RuntimeTests/StepsTest.cs
View file
Open in desktop

This file was deleted.

Loading