Report binding problems to binding registry and show them as errors during test execution #2663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gasparnagy
force-pushed
the
report_binding_problems_as_errors
branch
from
44f34f9
to
5419212
Compare
gasparnagy
changed the title
|
@SabotageAndi the PR exposes a tuple on the |
|
I would not put a tuple into a public interface. Feels wrong for me. |
|
@SabotageAndi OK, I agree. I will fix it |
|
@SabotageAndi pushed a new version without the tuple |
SabotageAndi
approved these changes
Nov 8, 2022
|
@gasparnagy Ready to merge? |
|
@SabotageAndi yes, done. |
gasparnagy
added a commit
that referenced
this pull request
Nov 9, 2022
* master: Report binding problems to binding registry and show them as errors during test execution (#2663) Fix for SF2649: Aggregate exceptions lost from async step definitions (#2667) # Conflicts: # TechTalk.SpecFlow/Bindings/BindingInvoker.cs # Tests/TechTalk.SpecFlow.RuntimeTests/Bindings/BindingInvokerTests.cs
Code-Grump
pushed a commit
to Code-Grump/SpecFlow
that referenced
this pull request
Mar 29, 2023
…uring test execution (SpecFlowOSS#2663) * Refactor BindingSourceProcessor to collect binding errors * Fix BindingSourceProcessorStub * Add tests & fixes * collect type load errors * Extend changelog * Replace tuple with a class on the IBindingRegistry interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some generic binding errors (e.g.
[Binding]on a generic type) were not properly reported as errors so far, only as warnings, but those are usually not visible by test runners. Some of these errors were causing strange exceptions during execution, but it was hard to trace them back to the source problem.Also type load exceptions blocked the discovery process that causes problems with tooling (e.g. VS) that uses the binding registry builder to discover the step definitions.
This PR introduces validity of loaded binding registry and provides a way to query these errors from the binding registry. During test execution, the invalid binding registry fails the tests by listing all collected error.
Types of changes
Checklist: