GetDiscreteEnum for when the enum is not used as property

[matthiaslischka]

Hi,
the tableRow extension method GetEnum<T> surprised me since it does not work as I would have expected by signature. Naturally I would have guessed that T is the enum I want to receive. Turned out it is the class where the enum I want to parse has to be used as property and the table row header represents the property name by which the enum is found.

So the very basic thing that should be changed is adding a generic type constraint on the GetEnum<T> method to allow only where T is class - preventing calls where T is an enum.

Furthermore I added a method of how I would have expected the GetEnum to work. Called it GetDiscreteEnum<T>. Usable for whenever the enum I want to parse is not mapped as property in a suitable class. Also offers the possibility of a default value for when the column is not always used in the feature step.

BR, Matthias

[SabotageAndi]

@darrencauthon Assists is your baby. ;-)

[matthiaslischka]

I want to stress once more that the GetEnum<T> does not work as one would guess.
The way cleaner solution would be to change GetEnum so that T is the Enum and not the Class Type as it is right now. There should be a extension like e.g. GetEnumFromClass<ClassType> if this behavior shall be available any longer.

However, since this is a actively used framework I wasn't sure how you go with breaking changes. Therefore I tried to only implement the minimum changes that are necessary IMHO.

Open for discussion...

BR Matthias

[304NotModified]

Is there a reason why this never has been merged? (Could think of some issues, but those will be wild guesses)

[SabotageAndi]

@304NotModified No idea why this is still open.
I resolved the merge conflict. When the build runs through, I will merge this. Better late than never.

[304NotModified]

Green! But the changelog is also needed. Unfortunately I can't push to the branch.

I think should be under API changes: @SabotageAndi

+ (breaking) tableRow.GetEnum<T>(..) has now a class contraint on T
+ (breaking) tableRow.GetTheEnumValue<T>(..) has now a class contraint on T
+ added tableRow.GetDiscreteEnum<T>

[SabotageAndi]

Finally, after more than 3 years this PR is merged. Sorry @matthiaslischka that it took so long.