Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoC for xUnit handling of @Ignore tag on a feature #968

Merged

Conversation

melchiork
Copy link
Contributor

Related to #956. Using FinalizeTestClass method of XUnitTestGeneratorProvider to mark all Scenarios and Outlines as ignored when a Feature is tagged with @ignore.
Not sure it this is the best/only way.

…thods get Skip attribute argument

As xUnit does not have a TestFixture equivalent this is the only way to ignore all Scenarios in a feature
@melchiork melchiork changed the title PoC for xUnit handlinf of @Ignore tag on a feature PoC for xUnit handling of @Ignore tag on a feature Nov 2, 2017
@SabotageAndi
Copy link
Contributor

Thanks for the PR! Looks good for me.
@gasparnagy It it ok for you?

@melchiork
Copy link
Contributor Author

@SabotageAndi Thanks. This solution will result in a Build Failed for the Feature if any of the individual Scenarios is marked with @ignore as well. Should this be addressed too?

@SabotageAndi
Copy link
Contributor

@melchiork ignore on Feature and Scenario level should not result in a build failed.
What is the error?

Could you post a code- behind of a small feature file?

@melchiork
Copy link
Contributor Author

@SabotageAndi Should now work with ignored Scenarios and Scenario Outlines in an ignored Feature.

@SabotageAndi
Copy link
Contributor

Thanks for the update. I will try to have a look at it on Tuesday.

@SabotageAndi SabotageAndi added this to the SpecFlow 2.3 milestone Nov 13, 2017
@SabotageAndi
Copy link
Contributor

Looks good for me.
But I have one last request: Could you add a scenario where only a scenario is ignored and not the whole feature file?

@melchiork
Copy link
Contributor Author

@SabotageAndi Done for xUnit and xUnit2.

@SabotageAndi SabotageAndi merged commit 35a6d23 into SpecFlowOSS:master Nov 22, 2017
@melchiork
Copy link
Contributor Author

@SabotageAndi Nice it's merged, the changelog isn't updated though, could you do it?

@melchiork melchiork deleted the IgnoreAllScenariosOnFeatureIgnore branch November 22, 2017 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants