Support for DoNotParallelize for MSTest V2 parallelism #996
Conversation
|
As this attribute is only available in MSTest V2 (according to your description, could you put a link to the docs of it here?), please add this to the MSTestV2 Test Generator you added. |
|
@SabotageAndi - here is the link to the mstest v2 doc containing the description for '[DoNotParallelize()]' |
|
I will have a look at it on friday. |
|
|
||
| namespace TechTalk.SpecFlow.Generator.UnitTestProvider | ||
| { | ||
| public class MsTestV2GeneratorProvider : MsTestGeneratorProvider |
There was a problem hiding this comment.
inherit from MsTest2010GeneratorProvider, so you can reuse much more code
| { | ||
| public class MsTestV2GeneratorProvider : MsTestGeneratorProvider | ||
| { | ||
| private const string CATEGORY_ATTR = "Microsoft.VisualStudio.TestTools.UnitTesting.TestCategoryAttribute"; |
There was a problem hiding this comment.
make the fields on MsTest2010GeneratorProvider protected if you need them in this class
|
|
||
| public override void SetTestClassCategories(TestClassGenerationContext generationContext, IEnumerable<string> featureCategories) | ||
| { | ||
| generationContext.CustomData["featureCategories"] = GetNonMSTestSpecificTags(featureCategories).ToArray(); |
There was a problem hiding this comment.
If you change the base class, this could be a simple base.SetTestClassCategories(generationContext, featureCategories).
No need to copy the whole function.
|
|
||
| public override void SetTestMethod(TestClassGenerationContext generationContext, CodeMemberMethod testMethod, string friendlyTestName) | ||
| { | ||
| base.SetTestMethod(generationContext, testMethod, friendlyTestName); |
There was a problem hiding this comment.
same as above,
call base.SetTestMethod on MsTest2010GeneratorProvider
|
|
||
| public override void SetTestMethodCategories(TestClassGenerationContext generationContext, CodeMemberMethod testMethod, IEnumerable<string> scenarioCategories) | ||
| { | ||
| IEnumerable<string> tags = scenarioCategories.ToList(); |
There was a problem hiding this comment.
again, base.SetTestMethodCategories on MsTest2010GeneratorProvider and only add the code you need
Adding feature @mstest:DoNotParallize to utilize MsTest V2's DoNotParallelize attribute.
Tag can be added to feature or scenario.
Running the Features/Scenarios using this attribute requires MsTest.TestFramework version > 1.2.0.
Just the generation of the '*.feature.cs' does not carry the dependency on MsTest.TestFramework version > 1.2.0.