Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribution of the DumpSMSAPassword edge with its documentation #626

Merged
merged 4 commits into from
May 7, 2023
Merged

Contribution of the DumpSMSAPassword edge with its documentation #626

merged 4 commits into from
May 7, 2023

Conversation

simondotsh
Copy link
Contributor

#624

When properties are read on computer objects, the attribute msds-hostserviceaccount is collected, then the contained distinguished names are resolved in order to retrieve object identifiers. On computer dump files, a new key named SMSA contains an array of IDs representing the sMSA installed on computers. When a dump file is imported, the UI looks for entries in SMSA, then adds relationships from the computers to the sMSA.

This pull request depends on SpecterOps/SharpHoundCommon#46 and SpecterOps/SharpHound#36.

As usual, feel free to alter any of this code.

@simondotsh
Copy link
Contributor Author

I just realized that the function buildComputerJsonNew expects the key SMSA to be there and if it's not, it crashes. This would make computer dump files collected prior this new version incompatible.

Should we perhaps set smsa to an empty array if computer.SMSA turns out to be undefined? Sounds like an easy fix with the potential of avoiding a headache to a few souls.

@JonasBK JonasBK changed the base branch from master to 4.3.1 May 7, 2023 18:15
@JonasBK JonasBK merged commit 4972d2e into SpecterOps:4.3.1 May 7, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants