chore: add test

cmd/api/src/daemons/datapipe/convertors.go

@@ -94,7 +94,6 @@ func convertDomainData(domain ein.Domain, converted *ConvertedData) {
 	domainTrustData := ein.ParseDomainTrusts(domain)
 	converted.RelProps = append(converted.RelProps, domainTrustData.TrustRelationships...)
 	converted.NodeProps = append(converted.NodeProps, domainTrustData.ExtraNodeProps...)
-
 }
 
 func convertGPOData(gpo ein.GPO, converted *ConvertedData) {

packages/go/ein/ad_test.go

@@ -0,0 +1,72 @@
+package ein_test
+
+import (
+	"github.com/specterops/bloodhound/ein"
+	"github.com/specterops/bloodhound/graphschema/ad"
+	"github.com/stretchr/testify/assert"
+	"testing"
+)
+
+func TestConvertObjectToNode_DomainInvalidProperties(t *testing.T) {
+	baseItem := ein.IngestBase{
+		ObjectIdentifier: "ABC123",
+		Properties: map[string]any{
+			"machineaccountquota":                    "1",
+			"minpwdlength":                           "1",
+			"pwdproperties":                          "1",
+			"pwdhistorylength":                       "1",
+			"lockoutthreshold":                       "1",
+			"expirepasswordsonsmartcardonlyaccounts": "false",
+		},
+		Aces:           nil,
+		IsDeleted:      false,
+		IsACLProtected: false,
+		ContainedBy:    ein.TypedPrincipal{},
+	}
+
+	result := ein.ConvertObjectToNode(baseItem, ad.Domain)
+	props := result.PropertyMap
+	assert.Contains(t, props, "machineaccountquota")
+	assert.Contains(t, props, "minpwdlength")
+	assert.Contains(t, props, "pwdproperties")
+	assert.Contains(t, props, "pwdhistorylength")
+	assert.Contains(t, props, "lockoutthreshold")
+	assert.Contains(t, props, "expirepasswordsonsmartcardonlyaccounts")
+	assert.Equal(t, 1, props["machineaccountquota"])
+	assert.Equal(t, 1, props["minpwdlength"])
+	assert.Equal(t, 1, props["pwdproperties"])
+	assert.Equal(t, 1, props["pwdhistorylength"])
+	assert.Equal(t, 1, props["lockoutthreshold"])
+	assert.Equal(t, false, props["expirepasswordsonsmartcardonlyaccounts"])
+
+	baseItem = ein.IngestBase{
+		ObjectIdentifier: "ABC123",
+		Properties: map[string]any{
+			"machineaccountquota":                    1,
+			"minpwdlength":                           1,
+			"pwdproperties":                          1,
+			"pwdhistorylength":                       1,
+			"lockoutthreshold":                       1,
+			"expirepasswordsonsmartcardonlyaccounts": false,
+		},
+		Aces:           nil,
+		IsDeleted:      false,
+		IsACLProtected: false,
+		ContainedBy:    ein.TypedPrincipal{},
+	}
+
+	result = ein.ConvertObjectToNode(baseItem, ad.Domain)
+	props = result.PropertyMap
+	assert.Contains(t, props, "machineaccountquota")
+	assert.Contains(t, props, "minpwdlength")
+	assert.Contains(t, props, "pwdproperties")
+	assert.Contains(t, props, "pwdhistorylength")
+	assert.Contains(t, props, "lockoutthreshold")
+	assert.Contains(t, props, "expirepasswordsonsmartcardonlyaccounts")
+	assert.Equal(t, 1, props["machineaccountquota"])
+	assert.Equal(t, 1, props["minpwdlength"])
+	assert.Equal(t, 1, props["pwdproperties"])
+	assert.Equal(t, 1, props["pwdhistorylength"])
+	assert.Equal(t, 1, props["lockoutthreshold"])
+	assert.Equal(t, false, props["expirepasswordsonsmartcardonlyaccounts"])
+}