Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: just schemagen improved with explicit yarn install step #102

Merged
merged 5 commits into from
Sep 19, 2023

Conversation

superlinkx
Copy link
Contributor

Description

Changes just schemagen to run a yarn install before attempting to run yarn format

Motivation and Context

just schemagen relies on node_modules to exist locally for yarn format and this can cause issues for downstream workspaces. This adds a local yarn install before attempting to run yarn format to keep things sane

How Has This Been Tested?

Ran just schemagen which not only worked when no node_modules folder existed, but also fixed some formatting we missed before.

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

Copy link
Contributor

@sircodemane sircodemane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@superlinkx superlinkx enabled auto-merge (squash) September 19, 2023 17:33
@superlinkx superlinkx merged commit cfc127c into main Sep 19, 2023
2 checks passed
@superlinkx superlinkx deleted the fix-just-schemagen branch September 19, 2023 17:41
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants