tasks 6 and 7 for #345 #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superlinkx
reviewed
Jan 26, 2024
| } else if hostName := parsedUrl.Hostname(); hostName == "" { | ||
| return "", fmt.Errorf("hostname not found in URL: %s", parsedUrl.String()) | ||
| } else { | ||
| return parsedUrl.Hostname(), nil |
There was a problem hiding this comment.
We already have the hostName var, but otherwise this logic seems good. I'd like to find out for sure if we need to attach any additional information on how the IP was derived for audit purposes, but that can be cleaned up in a follow up
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
X-Real-IPheader as this is easy to spoof.X-Forwarded-Forreturns a list of IPs, grab the originating IP (first one) from the listsuccessorfailure)