Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BED-4460: stop retrying /features request at app entrypoint #759

Merged
merged 1 commit into from
Aug 1, 2024
Merged

BED-4460: stop retrying /features request at app entrypoint #759

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/ui/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ const Inner: React.FC = () => {
const authState = useAppSelector((state) => state.auth);
const queryClient = useQueryClient();
const location = useLocation();
const featureFlagsRes = useFeatureFlags();
const featureFlagsRes = useFeatureFlags({ retry: false });

const darkMode = useAppSelector((state) => state.global.view.darkMode);

Expand Down
5 changes: 3 additions & 2 deletions cmd/ui/src/hooks/useFeatureFlags.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
// SPDX-License-Identifier: Apache-2.0

import { RequestOptions } from 'js-client-library';
import { useMutation, useQuery, useQueryClient } from 'react-query';
import { QueryOptions, UseQueryResult, useMutation, useQuery, useQueryClient } from 'react-query';
import { apiClient } from 'bh-shared-ui';

export type Flag = {
Expand All @@ -39,7 +39,8 @@ export const toggleFeatureFlag = (flagId: string | number, options?: RequestOpti
return apiClient.toggleFeatureFlag(flagId, options).then((response) => response.data);
};

export const useFeatureFlags = () => useQuery(featureFlagKeys.all, ({ signal }) => getFeatureFlags({ signal }));
export const useFeatureFlags = (queryOptions?: QueryOptions): UseQueryResult<Flag[], unknown> =>
useQuery(featureFlagKeys.all, ({ signal }) => getFeatureFlags({ signal }), queryOptions);

export const useFeatureFlag = (flagKey: string) =>
useQuery(featureFlagKeys.all, ({ signal }) => getFeatureFlags({ signal }), {
Expand Down
Loading