Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional AD properties #782

Merged
merged 6 commits into from
Aug 26, 2024
Merged

Additional AD properties #782

merged 6 commits into from
Aug 26, 2024

Conversation

JonasBK
Copy link
Collaborator

@JonasBK JonasBK commented Aug 8, 2024

Description

Add additional AD properties and pre-defined searches

Motivation and Context

This PR addresses: BP-792

Enables more to find more non-path security issues.

Should be merged and included in a release simultaneously or after this SharpHound change: BloodHoundAD/SharpHoundCommon#150

How Has This Been Tested?

Locally.

Screenshots (optional):

image

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

@JonasBK JonasBK added the enhancement New feature or request label Aug 8, 2024
Copy link
Contributor

@urangel urangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding limits to the new prebuilt queries similar to the recent updates from #773 but if they are not necessary the changes look good 👍

@AkechiShiro
Copy link

AkechiShiro commented Aug 15, 2024

Hello @JonasBK thanks for improvements, I'm curious as to which SharpHound version/release will we have to use to benefit from : BloodHoundAD/SharpHoundCommon#150 since this looks like a library for SharpHound, I'm not sure if the v4 is used at the moment for the latest release of SharpHound.

I see that the latest release is v4.0.4 beta from 2 weeks ago, I take it that this additional AD properties will come in the next release that will be made for the library but for upstream (SharpHound collector), we're still using v3 of the lib which is known to be stable.

@StephenHinck
Copy link
Collaborator

Hello @JonasBK thanks for improvements, I'm curious as to which SharpHound version/release will we have to use to benefit from : BloodHoundAD/SharpHoundCommon#150 since this looks like a library for SharpHound, I'm not sure if the v4 is used at the moment for the latest release of SharpHound.

I see that the latest release is v4.0.4 beta from 2 weeks ago, I take it that this additional AD properties will come in the next release that will be made for the library but for upstream (SharpHound collector), we're still using v3 which is stable.

This should be included, not in our next release, but the one following of BloodHound / SharpHound, tentatively scheduled for the week of September 9th.

@JonasBK JonasBK merged commit e6f6851 into main Aug 26, 2024
3 checks passed
@JonasBK JonasBK deleted the add-props branch August 26, 2024 15:13
@github-actions github-actions bot locked and limited conversation to collaborators Aug 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants