-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bed 4582 #787
Merged
Merged
Bed 4582 #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanieslamb
added
enhancement
New feature or request
api
A pull request containing changes affecting the API code.
labels
Aug 12, 2024
superlinkx
requested changes
Aug 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of things to hopefully reduce nested logic a bit and move some code back towards the database. Otherwise, the tests look pretty comprehensive and code looks as expected.
superlinkx
approved these changes
Aug 14, 2024
mvlipka
approved these changes
Aug 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated DeleteSavedQueries endpoint to check if query is public and if user has admin privileges.
Motivation and Context
This PR addresses: BED-4582
Why is this change required? What problem does it solve?
This change is part of the on-going initiative to saved cypher queries. This change will prevent users who are not admin from deleting public saved queries.
How Has This Been Tested?
Additional unit tests were added for additional functionality and all previous unit tests are passing.
Screenshots (optional):
Types of changes
Checklist: