Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactored saved query id parameter to always expect int64 #792

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

superlinkx
Copy link
Contributor

Description

Updated usage of the saved_query.id field to always expect int64. This includes reading the value in from the API handler and passing through to the database functions.

Motivation and Context

This PR addresses: BED-4698

Light refactoring to make savedQueryID usages more consistent overall, including always treating as an int64 and using the same naming conventions everywhere.

How Has This Been Tested?

Existing tests pass, no functional changes

Screenshots (optional):

Types of changes

  • Chore (a change that does not modify the application functionality)

Checklist:

@superlinkx superlinkx added enhancement New feature or request api A pull request containing changes affecting the API code. ticketed Ticket has been created internally for tracking labels Aug 13, 2024
@superlinkx superlinkx self-assigned this Aug 13, 2024
@stephanieslamb
Copy link
Contributor

Thank you for making this more consistent!

@superlinkx superlinkx merged commit 17dd2e2 into main Aug 14, 2024
3 checks passed
@superlinkx superlinkx deleted the BED-4698 branch August 14, 2024 17:05
@github-actions github-actions bot locked and limited conversation to collaborators Aug 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api A pull request containing changes affecting the API code. enhancement New feature or request ticketed Ticket has been created internally for tracking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants