Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bed-4168: fix: Inaccurate asset group counts #794

Merged
merged 2 commits into from
Aug 15, 2024
Merged

Conversation

mistahj67
Copy link
Contributor

Description

  • Abstracted the asset group node fetch logic for both the /api/v2/asset-groups/{asset_group_id}/members endpoint as well as the RunAssetGroupIsolationCollections analysis step to ensure both counts will be in line post analysis.
  • Added some missed licensing
  • Updated go mod / sum

Motivation and Context

This PR addresses: BED-4168
It was determined that the numbers were still not in sync due to additional filtering steps included in the endpoint handler that were not in the analysis step.

How Has This Been Tested?

Tests + Locally hit via rest client against test data

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist:

@mistahj67 mistahj67 self-assigned this Aug 14, 2024
@mistahj67 mistahj67 added the api A pull request containing changes affecting the API code. label Aug 14, 2024
@mistahj67 mistahj67 merged commit 84ceaae into stage/v5.14.0 Aug 15, 2024
3 checks passed
@mistahj67 mistahj67 deleted the BED-4168-2 branch August 15, 2024 16:24
@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api A pull request containing changes affecting the API code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants