Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert BED-4662 PR 767 #797

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Revert BED-4662 PR 767 #797

merged 1 commit into from
Aug 16, 2024

Conversation

mvlipka
Copy link
Contributor

@mvlipka mvlipka commented Aug 16, 2024

Description

Revert #767
We discussed using a new predicate instead of in:, but the changes were already staged for release.
This is to revert the implementation of the in: predicate in favor of BED-4726

Motivation and Context

Avoiding API changes from going out so that we may further improve on it before releasing to the public

How Has This Been Tested?

I tested the in: predicate to ensure it returns an error as the predicate is no longer supported
I then tested the supported predicates for the ListSavedQueries endpoint to ensure they still worked

Screenshots (optional):

in: no longer working:
image

eq: description working as intended
image

neq: description returns nothing
image

neq: description returns data
image

eq: name returns data
image

neq: name returns data
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

@mvlipka mvlipka changed the title revert BED-4662 PR 767 DRAFT: Revert BED-4662 PR 767 Aug 16, 2024
@mvlipka mvlipka marked this pull request as ready for review August 16, 2024 18:13
@mvlipka mvlipka changed the title DRAFT: Revert BED-4662 PR 767 Revert BED-4662 PR 767 Aug 16, 2024
Copy link
Contributor

@mistahj67 mistahj67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvlipka mvlipka merged commit c93425e into stage/v5.14.0 Aug 16, 2024
3 checks passed
@mvlipka mvlipka deleted the revert-767 branch August 16, 2024 18:49
@github-actions github-actions bot locked and limited conversation to collaborators Aug 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants