fix: prevent cyclic traversals in esc13 post processing #803
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe your changes in detail
This is an update to the traversal logic in ESC13 post processing for the func
groupIsContainedOrTrusted
.Motivation and Context
Why is this change required? What problem does it solve?
ESC13 post processing logic involved checking whether a group is contained or trusted based on the domain being processed. Domain trusts, which are often "bidirectional", were being traversed but there was no check in the traversal for whether a cycle was encountered. Encountering a cycle was drastically increasing analysis times as the reverse walk for the pathVisitor would go back and forth between the trusting domains.
The
ExpansionFilter
property of a TraversalPlan was exported so that it could be used outside of the package similarly to the already defined acyclic traversal functions.This PR addresses: BED-4378
How Has This Been Tested?
Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc.
Existing ESC13 integration tests continue to pass. A collection which prompted the issue was ingested via file upload before making changes to verify the long running analysis (hours). After the changes were made, the same collection was uploaded and the analysis time reduced to a couple of seconds.
Screenshots (optional):
Types of changes
Checklist: