Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BED-4363 fix: missing constraint on roles #809

Merged
merged 1 commit into from
Aug 22, 2024
Merged

BED-4363 fix: missing constraint on roles #809

merged 1 commit into from
Aug 22, 2024

Conversation

mistahj67
Copy link
Contributor

@mistahj67 mistahj67 commented Aug 22, 2024

Related BED-4363 follow-up fix

Description

Identified a missing constraint that breaks the idempotency of v5.15.0

Motivation and Context

This PR addresses: BED-4363

How Has This Been Tested?

Locally ran both and ensured no issues

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Database Migrations

Checklist:

Copy link
Contributor

@urangel urangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this out by checking out the v5.14.0 tag and spinning up to get the db in the state at the time. Then I switched to main and started the dev environment and confirmed the fatal error upon running the v5.15.0 migration.

I dropped my volumes rechecked out v5.14.0 tag and spun up to get the db in the state at the time again. This time, I checked out this branch instead of main and confirmed that the migration executed without errors. From what I can tell, this fix checks out. hank you, @mistahj67

@mistahj67 mistahj67 merged commit 4daf580 into main Aug 22, 2024
4 checks passed
@mistahj67 mistahj67 deleted the BED-4363 branch August 22, 2024 22:06
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants