BED-4718 Bump go version to v1.23.0 #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irshadaj
requested changes
Aug 27, 2024
There was a problem hiding this comment.
We also need to update Go version in the Dev readme:
https://github.com/SpecterOps/BloodHound/blob/e88dad44567d826d3e4ea21ca1ead1774ca1cfa6/DEVREADME.md
irshadaj
approved these changes
Aug 27, 2024
mvlipka
approved these changes
Aug 28, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR bumps the version of Go that BloodHound is built against to v1.23.0. It also bumps the version of
golangci-lintthat is installed withjust depsto1.60.3. This was due to a bug in the previous version that caused it to panic on go v1.23.0. Lastly, I included the latest round of formatting fixes fromjust prepare-for-codereview.NOTE: Developers will need to run
just depsto install the latest version ofgolangci-lintin order forjust prepare-for-codereviewto complete successfully.Motivation and Context
The goal of the BloodHound engineering team is to be on the latest version of Go. We have been on v1.21.6 for a longer than desired timeframe due to some concern about the for loop variable capture change introduced in v1.22.0. After getting some time to test the new version it does not appear that it has had any noticeable affects, so it's safe to bump the version.
How Has This Been Tested?
stbernardtasks working correctlyTypes of changes
Checklist: