-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toogle labels option #814
base: main
Are you sure you want to change the base?
Toogle labels option #814
Conversation
Good morning, @Palt, and thank you for another contribution! I have some functional feedback on your PR before I ask our Engineering team to review the code.
I appreciate the effort you've put into this, and I recognize this is a decent bit of rework on the changes you have already made. We do have some upcoming work planned for our team, where they can help take this across the line if you'd rather not rework! On a related note, I would love to send you a swag package to show our gratitude for your contributions to the product. If you can send me an email at shinck (AT) specterops (DOT) io with your shipping address, I'll get that on its way! |
Hi @StephenHinck, and thank you for great feedback! I’m happy to be able to contribute when I can as this is an awesome tool that I use quite a lot. Reading through what you’ve written it is as you say, this is not the way to implement it. I’ll blame it on my lack of understanding of the project and will continue digging a bit deeper into it to get a better grasp on it. I’ll see what I can do to see if I can implement the needed changes to get it to a state where you can agree with it. Regarding Swag: Thank you! I’ve sent you an email. |
I've re-done the PR and would say that it now aligns with what you described @StephenHinck. It is now a smaller change and far less complex from previous solution. Hope it is what you are looking for. |
@StephenHinck are the updates from @Palt what you are looking for? If so we can start getting this code reviewed. |
From a functional perspective, this matches our AC. The ticket is up at BED-4613 internally! |
Description
Added toggles to the
SettingsMenu
with the options to toggle the labels of Nodes and Edges.Motivation and Context
This PR addresses: #431
These changes will allow a user to toggle the labels and make it easier to hide potential sensitive data before taking a screenshot.
How Has This Been Tested?
Locally tested manually and using existing tests.
Screenshots (optional):
Types of changes
Checklist: