BED-4766: API Endpoint to List OIDC Providers #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…teractions to match new design
…rly backfill saml_providers with the new sso_providers key. Added new enum type for sso_provider types
…ed a mapping from AuthProvider to the new SSOProviderType enum
This was referenced Oct 4, 2024
juggernot325
added
the
blocked
ddlees
previously requested changes
Oct 9, 2024
iustinum
added
the
work in progress
iustinum
removed
the
blocked
mistahj67
requested changes
Oct 11, 2024
There was a problem hiding this comment.
Only blocked because the permission requirement needs to be removed. Otherwise this is looking great! I concede, the gorm joins feature is schnazzy just don't let @superlinkx know I said that out loud.
Also did you run prep-for-codereview 👀
Co-authored-by: mistahj67 <26472282+mistahj67@users.noreply.github.com>
mistahj67
approved these changes
Oct 15, 2024
Co-authored-by: mistahj67 <26472282+mistahj67@users.noreply.github.com>
Co-authored-by: mistahj67 <26472282+mistahj67@users.noreply.github.com>
Co-authored-by: mistahj67 <26472282+mistahj67@users.noreply.github.com>
Co-authored-by: mistahj67 <26472282+mistahj67@users.noreply.github.com>
iustinum
removed
the
work in progress
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces a unified SSO endpoint that provides detailed information on both OIDC and SAML providers. The goal is to offer a consolidated and accurate list of available authentication methods, ensuring that users are directed to the appropriate provider for successful authentication.
Motivation and Context
This PR addresses the requirements outlined in ticket BED-4766.
Previously, SSO providers were listed using the
GET /api/v2/saml/sso endpoint, which only supported SAML providers. With the addition of OIDC as an alternative authentication method to comply with FedRamp requirements, there is a need for a single, unified endpoint. This new endpoint will display information about both SAML and OIDC providers as a more flexible and agnostic approach. The unified endpoint will replace the existing SAML-only endpoint to ensure all authentication options are covered.How Has This Been Tested?
Unit Tests: Via
auth/sso_testto verify endpoint behavior.Integration Tests: Via
database/sso_providers_testto verify interaction with the database.Screenshots (optional):
Types of changes
Checklist: