Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add conversion logic to EIN to fix badly typed properties #909

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

rvazarkar
Copy link
Contributor

@rvazarkar rvazarkar commented Oct 22, 2024

Description

Adds logic to EIN to convert certain string properties to integers/bools as necessary.

Counterpart to BloodHoundAD/SharpHoundCommon#173

Motivation and Context

This PR addresses: https://specterops.atlassian.net/browse/BED-4928

How Has This Been Tested?

Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc.

Screenshots (optional):

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist:

packages/go/ein/ad.go Outdated Show resolved Hide resolved
packages/go/ein/ad.go Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants