Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing field in ZendeskApi_v2.Models.Satisfaction.SatisfactionRating #337

Closed
glangerocket opened this issue Jun 11, 2018 · 3 comments
Closed

Comments

@glangerocket
Copy link

Class is missing string field: Reason

Field Definition from Zendesk: https://developer.zendesk.com/rest_api/docs/core/satisfaction_ratings

Name: reason
Type: string
Comment: The reason for a bad rating given by the requester in a follow-up question. Satisfaction reasons must be enabled

@rwjdk
Copy link

rwjdk commented Jun 23, 2018

In order to write unit-tests for this then according to the API (https://developer.zendesk.com/rest_api/docs/core/satisfaction_ratings) the "Ask a follow-up question after a bad rating" option (https://support.zendesk.com/hc/en-us/articles/223152967#topic_t2m_c4b_rw) need to be enabled on the test account (+ Need to understand how the feature work).

Assume this is OK.

Can also just add the field (no big deal) but would not feel good just adding it without seeing the thing in action.

@mozts2005
Copy link
Member

@rwjdk feel free to add the needed feature to the zendesk account.

@rwjdk
Copy link

rwjdk commented Jun 24, 2018

Added Pull request on this

mozts2005 pushed a commit that referenced this issue Jul 3, 2018
…lemented (#349)

* Test "CanCreateTicketWithDueDate" can't run on PCs that use dd/MM/yyyy as time format

* Added Code to make tests work

* - Added support for issue #330
- Added support for CRUD operations of Comments on Articles and Posts

* Implementation of "Users.GetIncrementalUserExport" and "Users.GetIncrementalUserExportNextPage" (+Async versions)

* Changes to PR based on @mozts2005’s request

* Changed Assert Style

* Fixed Issue #345

+

Fixed test UserTests.CanCreateUpdateSuspendAndDeleteUser could fail as it assumed the user was among the 100 to be returned but it is not (at least not now).

* Added missing Obsolete Attribute

* Fix Issue #337 + Added missing tests
abc516 pushed a commit to abc516/ZendeskApi_v2 that referenced this issue Oct 30, 2019
…/was incorrectly implemented (Speedygeek#349)

* Test "CanCreateTicketWithDueDate" can't run on PCs that use dd/MM/yyyy as time format

* Added Code to make tests work

* - Added support for issue Speedygeek#330
- Added support for CRUD operations of Comments on Articles and Posts

* Implementation of "Users.GetIncrementalUserExport" and "Users.GetIncrementalUserExportNextPage" (+Async versions)

* Changes to PR based on @mozts2005’s request

* Changed Assert Style

* Fixed Issue Speedygeek#345

+

Fixed test UserTests.CanCreateUpdateSuspendAndDeleteUser could fail as it assumed the user was among the 100 to be returned but it is not (at least not now).

* Added missing Obsolete Attribute

* Fix Issue Speedygeek#337 + Added missing tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants