[Compose] - Add Gauges #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Scythe14
commented
Oct 30, 2023
•
Scythe14
commented
kelianClerc
reviewed
Oct 31, 2023
library-compose/src/main/java/com/spendesk/grapes/compose/gauge/GrapesGauge.kt
Outdated
Show resolved
Hide resolved
library-compose/src/main/java/com/spendesk/grapes/compose/gauge/GrapesGauge.kt
Show resolved
Hide resolved
| @Composable | ||
| fun GrapesGauge( | ||
| progress: Float, | ||
| color: Color, |
There was a problem hiding this comment.
Proposal:
a single GrapesGauge that takes a color: GaugeColor
GaugeColor is a sealed class :
sealed class GaugeColor {
data class Solid(val color: Color): GaugeColor
data class Stripped(stripeColor: Color, stripeColorSecondary: Color, stripSpacing: Dp): GaugeColor
}There was a problem hiding this comment.
The idea is to provide potentially multiple Gauges, so maybe in that case a List ?
library-compose/src/main/java/com/spendesk/grapes/compose/gauge/GrapesGauge.kt
Show resolved
Hide resolved
- Add GrapesGauge that displays a list of gauges - Make private all other gauges for clarity
…into task/compose-gauges
kelianClerc
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.