Create menu bottom sheet components #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
RomainGF
commented
Nov 30, 2023
•
RomainGF
commented
kelianClerc
reviewed
Nov 30, 2023
| title = title, | ||
| description = description, | ||
| illustration = illustration, | ||
| modifier = Modifier.padding( |
There was a problem hiding this comment.
missing bottom padding too ?
There was a problem hiding this comment.
Yes, and might be clearer if the padding is the inside the header as it's not header padding but text padding inside header in the design
| modifier = modifier, | ||
| ) { | ||
| Box( | ||
| content = { illustration() }, |
There was a problem hiding this comment.
shouldn't the alignment of the content be specified ?
It might be a dump comment. You only define a maxSize, so I guess that while the contnet is smaller, the box will just wrap it.
And if it's too big, it will be cropped so ne need to specify in which direction it will be cropped, it just shouldn't happen
There was a problem hiding this comment.
Yes should specify it if the content is smaller, even if there's no min size let's play it safe
kelianClerc
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.