Merge pull request #118 from Sphereon-Opensource/develop

New release
Sphereon-Opensource · Jul 31, 2023 · fc17cb5 · fc17cb5
2 parents bf86b36 + 33f5f9f
commit fc17cb5
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/packages/uni-resolver-registrar-api/src/api-functions.ts b/packages/uni-resolver-registrar-api/src/api-functions.ts
@@ -12,7 +12,7 @@ import {
   DidStateValue,
   ICreateDidEndpointOpts,
   IGlobalDidWebEndpointOpts,
-  IRequiredContext,
+  IRequiredContext, IResolveEndpointOpts,
 } from './types'
 
 export function createDidEndpoint(router: Router, context: IRequiredContext, opts?: ICreateDidEndpointOpts) {
@@ -39,7 +39,7 @@ export function createDidEndpoint(router: Router, context: IRequiredContext, opt
         return sendErrorResponse(response, 400, 'DID method not supported')
       }
       const provider = `did:${didMethod}`
-      const jobId = createRequest.jobId ?? `urn:uuid:${v4()}`
+      const jobId = createRequest.jobId ?? v4()
       let alias: string | undefined = undefined
       if (didMethod === 'web') {
         if (!did) {
@@ -137,9 +137,7 @@ async function agentDidToResolutionResult(context: IRequiredContext, did: string
 export function resolveDidEndpoint(
   router: Router,
   context: IRequiredContext,
-  opts?: ISingleEndpointOpts & {
-    mode?: 'local' | 'hybrid' | 'global'
-  }
+  opts?: IResolveEndpointOpts
 ) {
   if (opts?.enabled === false) {
     console.log(`Resolve DID endpoint is disabled`)

diff --git a/packages/uni-resolver-registrar-api/src/types.ts b/packages/uni-resolver-registrar-api/src/types.ts
@@ -92,7 +92,7 @@ export interface IDidAPIEndpointOpts {
   basePath?: string
   globalAuth?: GenericAuthArgs
   createDid?: ICreateDidEndpointOpts
-  resolveDid?: ISingleEndpointOpts
+  resolveDid?: IResolveEndpointOpts
   deactivateDid?: ISingleEndpointOpts
   getDidMethods?: ISingleEndpointOpts
   globalDidWebResolution?: IGlobalDidWebEndpointOpts
@@ -111,5 +111,9 @@ export interface ICreateDidEndpointOpts extends ISingleEndpointOpts {
   defaultMethod?: string
 }
 
+export interface IResolveEndpointOpts extends ISingleEndpointOpts {
+  mode?: 'local' | 'hybrid' | 'global'
+}
+
 export type DidWebServiceFeatures = 'did-web-global-resolution'
 export type DidApiFeatures = 'did-resolve' | 'did-persist'