-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/VDX-247 added a module for contact manager #123
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please look at the requirements. None of them are being met....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See remarks. Some are applicable to multiple parts of the code.
packages/contact-manager-rest-api/__tests__/database/databaseService.ts
Outdated
Show resolved
Hide resolved
packages/contact-manager-rest-api/src/contact-manager-api-server.ts
Outdated
Show resolved
Hide resolved
packages/contact-manager-rest-api/src/contact-manager-api-server.ts
Outdated
Show resolved
Hide resolved
packages/contact-manager-rest-api/src/contact-manager-api-server.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See remarks
packages/contact-manager-rest-api/src/contact-manager-api-server.ts
Outdated
Show resolved
Hide resolved
packages/contact-manager-rest-api/__tests__/database/test.sqlite
Outdated
Show resolved
Hide resolved
# Conflicts: # packages/data-store/src/index.ts # packages/data-store/src/migrations/generic/index.ts # packages/data-store/src/types/index.ts # pnpm-lock.yaml
# Conflicts: # packages/data-store/src/index.ts # packages/data-store/src/migrations/generic/index.ts # packages/data-store/src/types/index.ts # pnpm-lock.yaml
LGTM |
No description provided.