Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added identies to contacts #128

Merged
merged 4 commits into from
Sep 20, 2023
Merged

Added identies to contacts #128

merged 4 commits into from
Sep 20, 2023

Conversation

sanderPostma
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2023

Codecov Report

Merging #128 (de9aa03) into develop (ba38097) will decrease coverage by 11.52%.
Report is 621 commits behind head on develop.
The diff coverage is 56.20%.

❗ Current head de9aa03 differs from pull request most recent head 582fc67. Consider uploading reports for the commit 582fc67 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff              @@
##           develop     #128       +/-   ##
============================================
- Coverage    45.89%   34.37%   -11.52%     
============================================
  Files           65      138       +73     
  Lines         2412     6775     +4363     
  Branches       539     1596     +1057     
============================================
+ Hits          1107     2329     +1222     
- Misses        1305     4445     +3140     
- Partials         0        1        +1     
Files Changed Coverage Δ
packages/agent-config/src/agentCreator.ts 0.00% <0.00%> (ø)
packages/agent-config/src/dataSources.ts 0.00% <0.00%> (ø)
packages/agent-config/src/objectCreator.ts 0.00% <0.00%> (ø)
...ages/contact-manager-rest-api/src/api-functions.ts 0.00% <0.00%> (ø)
...manager-rest-api/src/contact-manager-api-server.ts 0.00% <0.00%> (ø)
...ckages/contact-manager/src/agent/ContactManager.ts 0.00% <0.00%> (ø)
...re/src/migrations/internal-migrations-ormconfig.ts 0.00% <0.00%> (ø)
...es/issuance-branding/src/agent/IssuanceBranding.ts 0.00% <0.00%> (ø)
packages/kv-store/src/key-value-store.ts 78.18% <ø> (ø)
packages/kv-store/src/keyv/keyv.ts 73.10% <ø> (ø)
... and 53 more

... and 68 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@nklomp nklomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the agent method to generate a didKey for you, then assign the did value to the contact. So we can actually use these DIDs from the agent as well. Also never do PII in DIDs!

didKeyIdentifier = await agent.didManagerCreate() // you might need to set the method if did:key isn't defined as the default method on the agent.

packages/contact-manager-rest-api/__tests__/agent.ts Outdated Show resolved Hide resolved
@sanderPostma
Copy link
Contributor Author

creating did:ion now
Also includes a fix that Bram made remotely after I ran into a typeorm issue.

@sanderPostma sanderPostma merged commit 1a69153 into develop Sep 20, 2023
1 check passed
@nklomp nklomp deleted the DPP-42 branch September 28, 2023 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants