-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added identies to contacts #128
Conversation
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## develop #128 +/- ##
============================================
- Coverage 45.89% 34.37% -11.52%
============================================
Files 65 138 +73
Lines 2412 6775 +4363
Branches 539 1596 +1057
============================================
+ Hits 1107 2329 +1222
- Misses 1305 4445 +3140
- Partials 0 1 +1
... and 68 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use the agent method to generate a didKey for you, then assign the did value to the contact. So we can actually use these DIDs from the agent as well. Also never do PII in DIDs!
didKeyIdentifier = await agent.didManagerCreate() // you might need to set the method if did:key isn't defined as the default method on the agent.
creating did:ion now |
No description provided.