Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error Prone doesn't support Java 14 #885

Merged
merged 1 commit into from
Jun 15, 2023
Merged

Conversation

dkfellows
Copy link
Member

This isn't well documented in the slightest, but
google/guava#6243 points to the right place (i.e., has useful information for people) and google/error-prone#3540 is the core issue (i.e., it is the same stack trace that we've observed).

This just marks the error prone checking run as not to be done for 14. It already was only done if enabled by Maven profile.

This isn't well documented in the slightest, but
google/guava#6243 points to the right place and
google/error-prone#3540 is the core issue.
@dkfellows dkfellows added bug Something isn't working blocker Do not release when one of these is open! labels Jun 15, 2023
@dkfellows dkfellows added this to the 7.0.0 milestone Jun 15, 2023
@dkfellows dkfellows self-assigned this Jun 15, 2023
@Christian-B
Copy link
Member

Needed for #884

Copy link
Member

@Christian-B Christian-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a MUST!

@Christian-B Christian-B added this pull request to the merge queue Jun 15, 2023
@dkfellows
Copy link
Member Author

Hmm, https://checkerframework.org/manual/ sort of hints that it doesn't support Java 14... but doesn't spell it out at all. Argh!

@Christian-B Christian-B merged commit 36ca264 into master Jun 15, 2023
@dkfellows dkfellows deleted the error-prone-errors branch June 15, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker Do not release when one of these is open! bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants