Skip to content
This repository has been archived by the owner on May 14, 2020. It is now read-only.

REQUEST-914-FILE-DETECTION #994

Closed
wants to merge 24 commits into from
Closed

REQUEST-914-FILE-DETECTION #994

wants to merge 24 commits into from

Conversation

spartantri
Copy link
Contributor

Initial file upload verification rule set

spartantri and others added 17 commits November 27, 2017 11:19
The rule will ignore non all upper case header names, which I don't think was the idea behind this rule.
3.2.  Header Fields
Each header field consists of a case-insensitive field name followed by a colon (":"), optional leading whitespace, the field value, and optional trailing whitespace.
removed to avoid discrepancies with origin
@spartantri spartantri changed the title V3.1/dev file upload REQUEST-914-FILE-DETECTION Jan 8, 2018
@spartantri
Copy link
Contributor Author

Hey @csanders-git @DUNE, there are conflicts with the util/regression-tests/config.py is there any reason to have those values?
I tested in several unix flavors, debian based use /var/log/apache2/error.log while RHEL uses httpd /var/log/httpd/error.log but both use the normal format not the reversed one eg [Sun Aug 24 03:23:01 2014], I will adjust my system to fit the defaults but if this is a common issue, it would be better to adjust the config.py to standard instead of custom values.

@spartantri spartantri self-assigned this Jan 10, 2018
@csanders-git csanders-git mentioned this pull request Mar 5, 2018
12 tasks
@spartantri
Copy link
Contributor Author

Hi @dune73, can you help me testing this out on one of your ngnix boxes? I works fine in mine apache but but as this one uses a few not so common features it may have compatibility issues so we may have to put this as an optional addition or find a way to make it compatible with all systems.

@dune73
Copy link
Contributor

dune73 commented Mar 6, 2018

I'll give it a shot and report back here.

@csanders-git
Copy link
Contributor

Can you rebase to the current v3.1/dev to get the updated ftw config.py for testing now that we've switched to ubuntu for our backend docker containers?

@spartantri
Copy link
Contributor Author

I'm having problems with the rebase stuff so better will open a new PR #1045 to keep it clean, closing this one

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants