Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented Preview #22

Merged
merged 4 commits into from
Jun 12, 2023
Merged

Implemented Preview #22

merged 4 commits into from
Jun 12, 2023

Conversation

faberf
Copy link
Contributor

@faberf faberf commented May 15, 2023

Preview with limit argument. Also includes nice formatting in the cli.

@Spiess Spiess mentioned this pull request May 17, 2023
Closed
Spiess
Spiess requested changes May 17, 2023
View reviewed changes
Copy link
Owner

@Spiess Spiess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!
A preview command is something that has been missing from the CottontailDB Python client for a long time.

I've highlighted some aspect that I think still need improvement, but I'm looking forward to merging this.

cottontaildb_client/cottontaildb_cli.py Show resolved Hide resolved
cottontaildb_client/cottontaildb_cli.py Outdated Show resolved Hide resolved
cottontaildb_client/cottontaildb_cli.py Outdated Show resolved Hide resolved
cottontaildb_client/cottontaildb_cli.py Outdated Show resolved Hide resolved
cottontaildb_client/cottontaildb_client.py Outdated Show resolved Hide resolved
cottontaildb_client/cottontaildb_client.py Outdated Show resolved Hide resolved
Spiess
Spiess requested changes May 27, 2023
View reviewed changes
Copy link
Owner

@Spiess Spiess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the fixes. I did find a few more very minor points which I would like to have addressed, but after these changes the pull request should be mergeable.

cottontaildb_client/cottontaildb_cli.py Show resolved Hide resolved
cottontaildb_client/cottontaildb_cli.py Outdated Show resolved Hide resolved
cottontaildb_client/cottontaildb_cli.py Outdated Show resolved Hide resolved
@Spiess Spiess merged commit 6f5ad72 into Spiess:main Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Spiess Spiess Spiess approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@faberf @Spiess