Skip to content

Commit

Permalink
#3058: Remove world limit
Browse files Browse the repository at this point in the history
  • Loading branch information
@md-5
md-5 committed Apr 5, 2021
1 parent a4e5f50 commit 8d783aa
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions protocol/src/main/java/net/md_5/bungee/protocol/packet/Login.java
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package net.md_5.bungee.protocol.packet;

import com.google.common.base.Preconditions;
import io.netty.buffer.ByteBuf;
import java.util.HashSet;
import java.util.Set;
Expand Down Expand Up @@ -53,8 +52,6 @@ public void read(ByteBuf buf, ProtocolConstants.Direction direction, int protoco

worldNames = new HashSet<>();
int worldCount = readVarInt( buf );
Preconditions.checkArgument( worldCount < 128, "Too many worlds %s", worldCount );

for ( int i = 0; i < worldCount; i++ )
{
worldNames.add( readString( buf ) );
Expand Down

3 comments on commit 8d783aa

@ham1255
Copy link

@ham1255 ham1255 commented on 8d783aa May 14, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for asking about this, but why this was implemented anyways and removed now?

@md-5
Copy link
Member Author

@md-5 md-5 commented on 8d783aa May 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The limit isn't needed because the server is presumed to be non-malicious

@Janmm14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also there are servers out there who hit this limit legit by just having many worlds or one world per player.

Please sign in to comment.