Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support of (enrichment) option #308

Closed
yuri-sergiichuk opened this issue Jan 31, 2019 · 0 comments · Fixed by #312
Closed

Drop support of (enrichment) option #308

yuri-sergiichuk opened this issue Jan 31, 2019 · 0 comments · Fixed by #312
Assignees

Comments

@yuri-sergiichuk
Copy link
Contributor

yuri-sergiichuk commented Jan 31, 2019

It was decided that (enrichment) option should be removed. The reason behind such a decision is a potential ability of a developer to define enrichments from different places at the same time: e.g. from an event that should be enriched and from the enrichment itself.

message Enrichment {
    string user_name = 1 [(by) = "user_id];
}

message SecondEnrichment {
    option (enrichment_for) = "Event";

    string user_address = 1 [(by) = "user_id];
}

message Event {
    option (enrichment) = "Enrichment";
    
    int32 user_id = 1;
}

The enrichment is smth that adds some additional information on top of a message and it is not a responsibility of the message to define how this information is linked to the message itself.

Enrichments should be defined only with (enrichment_for) option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant