Remove (enrichment) option #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not allow omitting (enrichment_for). Do not allow nested enrichments.
Codecov Report
@@ Coverage Diff @@
## master #312 +/- ##
============================================
+ Coverage 73.54% 74.12% +0.58%
- Complexity 2208 2221 +13
============================================
Files 353 352 -1
Lines 9434 9419 -15
Branches 595 592 -3
============================================
+ Hits 6938 6982 +44
+ Misses 2343 2284 -59
Partials 153 153 |
alexander-yevsyukov
requested changes
Feb 4, 2019
tools/model-compiler/src/main/java/io/spine/tools/compiler/enrichment/EnrichmentMapBuilder.java
Outdated
Show resolved
Hide resolved
|
@alexander-yevsyukov PTAL again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #308.
(enrichment)option is not available anymore. The contract of(enrichment_for)and(by)options are refined and made stricter.Further changes to the enrichment functionality should be done in the following PRs. (e.g., see #310 and #311).