Extend the Field utility with presentIn(...) and isNested() methods
#498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@armiol, @dmdashenkov PTAL. |
Codecov Report
@@ Coverage Diff @@
## master #498 +/- ##
===========================================
+ Coverage 72.79% 72.8% +0.01%
- Complexity 2608 2611 +3
===========================================
Files 454 454
Lines 10560 10566 +6
Branches 612 613 +1
===========================================
+ Hits 7687 7693 +6
Misses 2697 2697
Partials 176 176 |
armiol
approved these changes
Nov 15, 2019
There was a problem hiding this comment.
@dmitrykuzmin LGTM. However, can you please rename the PR (and maybe tweak the description), so that it makes sense in terms of base. There is no client here.
dmitrykuzmin
changed the title
Field utility with presentIn(...) and isNested() methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the
Fieldwith some utilities needed by the core-java#1197.Spine
baseversion advances to1.2.3.