Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kotlin code generation #747

Merged
merged 14 commits into from
Oct 12, 2022
Merged

Add Kotlin code generation #747

merged 14 commits into from
Oct 12, 2022

Conversation

alexander-yevsyukov
Copy link
Contributor

@alexander-yevsyukov alexander-yevsyukov commented Oct 12, 2022

This PR adds Kotlin code generation for proto types. It also updates ProtoTaskExtensions.kt for adding file-wide suppression of deprecations to the generated Kotlin code.

The Protobuf version was rolled back because 3.21.7 does not add visibility modifiers to the generated code. See my comments for this PR for the details on the issue.

@alexander-yevsyukov
Copy link
Contributor Author

@armiol, @dmdashenkov, it works, but I had to reduce the explicit API level to warnings. There are many of them.

And I still don't know how to suppress them in a good way.

@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Merging #747 (6eccd0d) into master (a1a4b45) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #747   +/-   ##
=========================================
  Coverage     74.67%   74.67%           
  Complexity     1352     1352           
=========================================
  Files           198      198           
  Lines          4786     4786           
  Branches        360      360           
=========================================
  Hits           3574     3574           
  Misses         1085     1085           
  Partials        127      127           

@alexander-yevsyukov alexander-yevsyukov self-assigned this Oct 12, 2022
@alexander-yevsyukov
Copy link
Contributor Author

Protofuf guys say they've fixed it.

@alexander-yevsyukov
Copy link
Contributor Author

Rolling back to 3.19.6 solves the problem.

I'm a bit puzzled, the fix was 26 days ago. 3.21.7 was released 13 days ago. The merge was into main. The fix should have been included into the release. But I don't see the mentioning in the release notes.

@alexander-yevsyukov alexander-yevsyukov marked this pull request as ready for review October 12, 2022 15:57
@alexander-yevsyukov alexander-yevsyukov merged commit 9c47e96 into master Oct 12, 2022
@alexander-yevsyukov alexander-yevsyukov deleted the go-kotlin branch October 12, 2022 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants