-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Stringifiers
to Kotlin
#806
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: * Add inline ext. fun. * Add `stringify` alias fun for static imports in Java (resolves #799).
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #806 +/- ##
============================================
- Coverage 74.64% 74.55% -0.10%
+ Complexity 1144 1129 -15
============================================
Files 180 180
Lines 4205 4189 -16
Branches 335 335
============================================
- Hits 3139 3123 -16
Misses 938 938
Partials 128 128 |
... avoiding duplication and irrelevant libraries.
... in favor of the Text library.
armiol
approved these changes
Nov 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Stringifiers
to Kotlin object, adding convenience extension functions to it.stringify()
method per SimplifyStringifier.toString
call in Java #799.3.25.0
. See note on this below.Updated usage of
protobuf
dependencyVersion 3.25.0 of Protobuf added
.proto
files tocom.google.protobuf:protobuf-kotlin
artifact. Now.proto
files are available from bothcom.google.protobuf:protobuf-java
and the Kotlin artifact.We used to add all the Protobuf libraries to the
protobuf
dependency for simplicity. SInce only one library (protobuf-java
) had.proto
source code, it did not cause any problems, until the3.25.0
update.The solution is to pass only
protobuf-java
to theprotobuf
dependency.Other changes
Text
class was deprecated in favor of the Spine Text library.Iterable.joinByLines()
Kotlin ext. fun was introduced to be used instead ofJoiner
onSystem.lineSeparator()
wherever possible.Stringifiers
.