Create TypeUrl via GenericDescriptor
#839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and deprecate `from()` static factories.
armiol
approved these changes
Dec 2, 2024
yevhenii-nadtochii
approved these changes
Dec 2, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #839 +/- ##
============================================
- Coverage 75.17% 75.08% -0.09%
+ Complexity 1173 1171 -2
============================================
Files 190 190
Lines 4286 4283 -3
Branches 344 344
============================================
- Hits 3222 3216 -6
- Misses 933 936 +3
Partials 131 131 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces static factory method for
TypeUrlviaGenericDescriptor. Previously, we had factories acceptingDescriptor,EnumDescriptor, andServiceDescriptor. But in factGenericDescriptorhas everything we need for creatingTypeUrl.Corresponding static factories named
from()were deprecated.